alloc fs: use case-insensitive check for reads of secret/private dir #24125
+80
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Client FS APIs, we check to ensure that reads don't traverse into the allocation's secret dir and private dir. But this check can be bypassed on case-insensitive file systems (ex. Windows, macOS, and Linux with obscure ext4 options enabled). This allows a user with `read-fs` permissions but not `alloc-exec` permissions to read from the secrets dir. This changeset updates the check so that it's case-insensitive. This risks false positives for escape (see linked Go issue), but only if a task without filesystem isolation deliberately writes into the task working directory to do so, which is a fail-safe failure mode. Ref: golang/go#18358
tgross
force-pushed
the
b-case-sensitive-template-check
branch
from
cb6b817
to
4f1cbe3
Compare
tgross
added
backport/ent/1.7.x+ent
dduzgun-security
approved these changes
Oct 3, 2024
schmichael
approved these changes
Oct 3, 2024
Comment on lines
+4
to
+5
| //go:build !linux | ||
| // +build !linux |
There was a problem hiding this comment.
BSDs are gonna be sad, but we don't officially support them anyway. Perhaps:
Suggested change
| //go:build !linux | |
| // +build !linux | |
| //go:build darwin || windows |
(can we drop the old // +build way? it was replaced 3+ years ago)
There was a problem hiding this comment.
(can we drop the old // +build way? it was replaced 3+ years ago)
I think so, but we've got roughly a zillion of those so let's do it all in one big sed in its own PR. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Client FS APIs, we check to ensure that reads don't traverse into the allocation's secret dir and private dir. But this check can be bypassed on case-insensitive file systems (ex. Windows, macOS, and Linux with obscure ext4 options enabled). This allows a user with
read-fspermissions but notalloc-execpermissions to read from the secrets dir.This changeset updates the check so that it's case-insensitive. This risks false positives for escape (see linked Go issue), but only if a task without filesystem isolation deliberately writes into the task working directory to do so, which is a fail-safe failure mode.
Ref: golang/go#18358
Ref: https://hashicorp.atlassian.net/browse/NET-10664