[ui] Versions page diff dropdown: z-index so you can click on labels #24068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
b-ui/fix-versions-compare-z-index
branch
from
22443bd
to
e0db44c
Compare
Ember Test Audit comparison
|
pkazmierczak
approved these changes
Sep 26, 2024
Deliberately — it detects a visual diff that was intended (moved the stuff up in the z-index and over to the right). I've approved the changes in Percy now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that while the radio button itself was clickable, the labels in the dropdown fell beneath the
.timelinetext and so weren't clickable, and in some browsers even showed up behind the timeline itself.