Conversation
10 tasks
tgross
force-pushed
the
f-tproxy-submit-hooks
branch
from
52fd5ea to
6dc3e0f
Compare
tgross
force-pushed
the
f-tproxy-submit-hooks
branch
from
6dc3e0f to
fc27cdd
Compare
tgross
force-pushed
the
f-tproxy-submit-hooks
branch
from
fc27cdd to
f8466ae
Compare
gulducat
approved these changes
Apr 3, 2024
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
couple tidbits for ya, lgtm!
tgross
added a commit
that referenced
this pull request
Apr 5, 2024
Add a constraint on job submission that requires the `consul-cni` plugin fingerprint whenever transparent proxy is used. Add a validation that the `network.dns` cannot be set when transparent proxy is used, unless the `no_dns` flag is set.
philrenaud
pushed a commit
that referenced
this pull request
Apr 18, 2024
Add a constraint on job submission that requires the `consul-cni` plugin fingerprint whenever transparent proxy is used. Add a validation that the `network.dns` cannot be set when transparent proxy is used, unless the `no_dns` flag is set.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a constraint on job submission that requires the
consul-cniplugin fingerprint whenever transparent proxy is used. Add a validation that thenetwork.dnscannot be set when transparent proxy is used, unless theno_dnsflag is set.This PR targets the feature branch.
Ref: #20175