Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(job-specification/periodic): Add enabled toggle #14767

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

pop
Copy link
Contributor

@pop pop commented Sep 30, 2022

This is probably undocumented for a reason, but the enabled toggle in the periodic stanza is very useful so I figured I try adding it to the docs.

The feature has been secretly avaliable since #9142 and was called out in that PR as being a dubious addition, only added to avoid regressions in the update to hcl2.

The use case for disabling a periodic job in this way is to prevent it from running without modifying the schedule. Ideally Nomad would make it more clear that this was the case, and allow you to force a run of the job, but even with those rough edges I think users would benefit from knowing about this toggle.

@vercel
Copy link

vercel bot commented Sep 30, 2022

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@tgross tgross added theme/docs Documentation issues and enhancements backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Oct 3, 2022
This is probably undocumented for a reason, but the `enabled` toggle in the
`periodic` stanza is very useful so I figured I try adding it to the docs.

The feature has been secretly avaliable since hashicorp#9142 and was called out in that
PR as being a dubious addition, only added to avoid regressions.

The use case for disabling a periodic job in this way is to prevent it from
running without modifying the schedule. Ideally Nomad would make it more clear
that this was the case, and allow you to force a run of the job, but even with
those rough edges I think users would benefit from knowing about this toggle.
@tgross tgross force-pushed the pop/document-periodic-enabled branch from 5e01129 to 8d0a99c Compare October 3, 2022 19:00
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pop! Thanks for opening this... in retrospect I regret the notion of having undocumented behaviors like this. So 👍

There's was something weird about the commits you had in this PR, where an older version of the repo had been merged on top of the content here, and that broke the docs builder I've taken your commit and cherry-picked it onto a clean branch and then pushed onto this PR. Once the docs builder is green I can get this merged. Thanks!

@tgross
Copy link
Member

tgross commented Oct 3, 2022

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line theme/docs Documentation issues and enhancements
Projects
Development

Successfully merging this pull request may close these issues.

2 participants