deps: update Nomad jobspec dep to 1.0.0 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
lgtm
in case you didn't notice, we updated the TF provider to pull the jobspec in. it required a little bit of dependency-wrangling on our part because of some TF stuff, not sure what the impact would be in levant:
hashicorp/terraform-provider-nomad#161
lgfa29
approved these changes
Oct 30, 2020
|
@cgbaker and @lgfa29 Levant suffers compared to the provider as it passes around the API job object and the import is screwed up by the API replace line within Nomad's |
cgbaker
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the internal jobspec parsing to reflect Nomad 1.0.0 and includes updates to the Nomad API and Consul API packages.