Swap proxy-agent with https-proxy-agent to defeat legacy ftp package issue
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2022
magnetikonline
commented
May 2, 2022
Comment on lines
-546
to
-554
| "ftp": { | ||
| "version": "0.3.10", | ||
| "resolved": "https://registry.npmjs.org/ftp/-/ftp-0.3.10.tgz", | ||
| "integrity": "sha1-kZfYYa2BQvPmPVqDv+TFn3MwiF0=", | ||
| "requires": { | ||
| "readable-stream": "1.1.x", | ||
| "xregexp": "2.0.0" | ||
| } | ||
| }, |
There was a problem hiding this comment.
As noted, offending ftp package now gone.
|
Thanks @jpogran 👍 |
jpogran
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #42 - where the
ftppackage is causing the following warning when this package is used:Some investigation/further digging - the existing
proxy-agentpackage simply wraps a number of packages for HTTP proxies, socks proxies/pac/etc. - but all we really need/want isHTTPS_PROXYsupport.Thus, we can swap this out for the child
https-proxy-agentpackage - and avoid bringing along all the cruft of additional packages we don't need - and in that, the offendingftppackage. 🎉.Have tested locally using Proxyman and
HTTPS_PROXY="http://127.0.0.1:9090"- can see successful requests being made via Proxyman as the proxy.