Skip to content

fix(json): correct 'occured' -> 'occurred' in ParseFile diagnostics#792

Closed
SAY-5 wants to merge 1 commit intohashicorp:mainfrom
SAY-5:fix-json-public-occured-typo
Closed

fix(json): correct 'occured' -> 'occurred' in ParseFile diagnostics#792
SAY-5 wants to merge 1 commit intohashicorp:mainfrom
SAY-5:fix-json-public-occured-typo

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented Apr 15, 2026

json/public.go raised two diagnostics with the wrong spelling:

Detail: fmt.Sprintf("The file %q was opened, but an error occured while closing it.", filename)  // line 111
Detail: fmt.Sprintf("The file %q was opened, but an error occured while reading it.", filename)  // line 122

Both messages are surfaced in HCL diagnostic output to end users when ParseFile hits a filesystem error. Replace occured with occurred. go build ./... and go test ./json/ both pass against current main.

json/public.go raised two diagnostics with 'an error occured while
closing/reading it'. Both messages are surfaced in HCL diagnostic
output to end users when ParseFile encounters a filesystem error.
Replace with 'occurred'. go build ./... and go test ./json/ stay
clean.
@SAY-5 SAY-5 requested a review from a team as a code owner April 15, 2026 16:10
@hashicorp-cla-app
Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


SAY-5 seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
@hashicorp-cla-app
Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


SAY-5 seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@crw
Copy link
Copy Markdown
Contributor

crw commented Apr 15, 2026

Thanks for this submission. If you are interested in having this reviewed, please sign the CLA per #792 (comment). Note that we do not normally accept PRs that make small changes to text output or comments. However, I will leave this open as occasionally these do get picked up and accepted. Thanks again!

@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 28, 2026

Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, #794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise.

@SAY-5 SAY-5 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants