decoder: allow objects in for_each
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dbanck
approved these changes
Oct 11, 2023
Yes - I think it should probably get suppressed in hover data as well. We could also consider separate explicit warning or info diagnostic to discourage users from using objects in that context. I will create a ticket and track it on my TODOs in the meantime. |
|
Follow-up issue created: hashicorp/terraform-ls#1473 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Relevant LOC in Terraform: https://github.com/hashicorp/terraform/blob/07b814c030daae39dea764571bef9cecf26e49be/internal/terraform/eval_for_each.go#L275-L284
As the in-line comment says:
Objects are still supported for backwards-compatible reasons but in general should be avoided. We add it here because otherwise valid configuration would be flagged as invalid. We cannot suppress it in completion (yet) or otherwise inform the user of this anti-pattern though.
Before
After