reference: Fix panic when trying to shorten origin address #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the in-line comment explains, previously we'd try to "shorten" the origin address by actually "growing" it.
In theory this could have happened prior to #150 but it apparently never did, or nobody reported it. It would require an origin with less segments than the compared target. In most (all?) cases, the targets have at least 2 segments and so that would require comparison with a single-segment origin, such as
foo. This was also additionally gated by another condition, which was somewhat naively modified to account for local addresses and that condition is no longer necessary now.