Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for local references #149

Closed
wants to merge 19 commits into from
Closed

Support for local references #149

wants to merge 19 commits into from

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 4, 2022 •
edited
Loading

TODO

Reference Matching Logic:

  • fix panic when trying to shorten a local reference - @radeksimko
  • fix mismatch of global nested target with local address set - @radeksimko

Completion:

  • fix broken count.index completion - @dbanck

Self References:

  • Filter invalid self during origin collection
  • Fix broken references output
  • Use localAddr for hover
  • Use localAddr for autocompletion
  • Use localAddr for semantic tokens
  • Refactoring to use collected origins
    • for hover
    • for semantic tokens
  • Add more tests

@radeksimko radeksimko mentioned this pull request Nov 4, 2022
Merged
@dbanck dbanck force-pushed the f-local-addr branch 3 times, most recently from 13b9a21 to e81bda3 Compare November 11, 2022 16:27
@radeksimko
Copy link
Member Author

Closing in favour of #163 and other PRs which were already merged in.

@radeksimko radeksimko closed this Nov 23, 2022
@radeksimko radeksimko deleted the f-local-addr branch January 16, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck