Merged
Conversation
jimlambrt
approved these changes
Oct 5, 2023
talanknight
approved these changes
Oct 5, 2023
sgmiller
approved these changes
Oct 5, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, running Read twice on Windows will result in the second call immediately exiting. This is because the first call leaves a
\nin the stdin buffer on Windows since Windows sends\r\non Enter.This change causes us to loop around again on Windows when we receive an
\rso that we can then consume the\nand drain it. This fixes the issue. Note the caveats in the comment, which I'm not worried about.