Conversation
…mes and improve test scope generation
…ts and improve query handling
ChandraSGadde
previously approved these changes
Dec 18, 2025
tmessi
reviewed
Jan 7, 2026
tmessi
approved these changes
Jan 9, 2026
ChandraSGadde
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the KMS key reconciliation process by optimizing how missing data keys are detected and handled across multiple scopes and purposes. The main improvement is the introduction of a new repository method that efficiently identifies which scopes lack specific data keys, enabling batch processing and reducing unnecessary lookups. Comprehensive tests have also been added to ensure correctness, including edge cases and large batches. This addresses ICU-17643 and ICU-17641
Key improvements to key reconciliation logic:
ListScopesMissingDataKey, which efficiently returns a map of missing data keys for each purpose across a list of scopes, supporting batching for large requests.Kms.ReconcileKeysmethod to use the new repository method, allowing it to only process scopes and purposes that are actually missing data keys, improving performance and clarity.Testing improvements:
ListScopesMissingDataKey, covering cases such as missing keys, missing root keys, all keys present, mixed scenarios, and large batch operations.Supporting changes:
postgresScopesMissingDataKeyQuerysqliteScopesMissingDataKeyQuery, to efficiently find missing data keys for given scopes and purposes.