Skip to content

wrappers/awskms: replace use of suite#294

Merged
johanbrandhorst merged 1 commit intoegrant-aws-sdk-v2from
jbrandhorst-aws-sdk-v2-without-suite
Oct 21, 2025
Merged

wrappers/awskms: replace use of suite#294
johanbrandhorst merged 1 commit intoegrant-aws-sdk-v2from
jbrandhorst-aws-sdk-v2-without-suite

Conversation

@johanbrandhorst
Copy link
Copy Markdown
Contributor

Instead of using a test suite, use vanilla require and assert packages for assertions and standard library testing
patterns for tests and sub tests.

Instead of using a test suite, use vanilla require and assert
packages for assertions and standard library testing
patterns for tests and sub tests.
Copy link
Copy Markdown
Contributor

@emilia-grant emilia-grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanbrandhorst johanbrandhorst marked this pull request as ready for review October 21, 2025 20:30
@johanbrandhorst johanbrandhorst merged commit 025170c into egrant-aws-sdk-v2 Oct 21, 2025
2 checks passed
@johanbrandhorst johanbrandhorst deleted the jbrandhorst-aws-sdk-v2-without-suite branch October 21, 2025 20:30
johanbrandhorst added a commit that referenced this pull request Nov 12, 2025
* update to aws sdk v2

* restruct tests into suite

* wrappers/awskms: replace use of suite (#294)

Instead of using a test suite, use vanilla require and assert
packages for assertions and standard library testing
patterns for tests and sub tests.

* update comment on KmsApi

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

* update go-secure-stdlib

---------

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants