Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin azure providers and remove Terraform output #79

Merged
merged 3 commits into from
Jan 10, 2019
Merged

pin azure providers and remove Terraform output #79

merged 3 commits into from
Jan 10, 2019

Conversation

alvin-huang
Copy link
Contributor

@alvin-huang alvin-huang commented Jan 10, 2019 •
edited
Loading

  1. Pinning the azure provider for azure-vmss will prevent erroring on:
    network_profile.*.ip_configuration.*.primary now required for azure_virtual_machine_scale_set terraform-provider-azurerm#2035 which creates:
Error: module.vmss.azurerm_virtual_machine_scale_set.test: "network_profile.0.ip_configuration.0.primary": required field is not set

  1. pinning the azure provider for azurerm to something we know works as of today.

  2. removing Terraform output so we don't show public IPs (not a huge deal since they do get destroyed at the end but good for sanity).

@alvin-huang alvin-huang merged commit 3185905 into master Jan 10, 2019
pearkes
pearkes reviewed Jan 10, 2019
View reviewed changes
Copy link
Contributor

@pearkes pearkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post merge 👍

@alvin-huang alvin-huang deleted the remove-azure-output branch January 11, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearkes pearkes pearkes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvin-huang @pearkes