Skip to content

Add default for MaxExpressions#112

Merged
mismithhisler merged 2 commits intomainfrom
b-add-default-max-expressions
Oct 17, 2025
Merged

Add default for MaxExpressions#112
mismithhisler merged 2 commits intomainfrom
b-add-default-max-expressions

Conversation

@mismithhisler
Copy link
Copy Markdown
Member

@mismithhisler mismithhisler commented Oct 16, 2025

Description

Evaluating large numbers of expressions causes memory consumption to balloon significantly. While this can be set by consumers of the library, it is helpful to set a sane default that can be overridden if a user chooses. This reduces the likelihood of accidental OOM failures.

Related Issue

How Has This Been Tested?

See added unit test.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@mismithhisler mismithhisler requested review from a team as code owners October 16, 2025 18:51
@mismithhisler mismithhisler self-assigned this Oct 16, 2025
Comment thread bexpr.go
Evaluating large numbers of expressions causes memory consumption to
balloon significantly. While this can be set by consumers of the
library, it is helpful to set a sane default that can be overridden if a
user chooses. This reduces the likelihood of accidental OOM failures.
@mismithhisler mismithhisler force-pushed the b-add-default-max-expressions branch from dc7dd79 to 0311ded Compare October 16, 2025 19:09
Comment thread bexpr_test.go
Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mismithhisler mismithhisler merged commit 947a4ef into main Oct 17, 2025
4 checks passed
@mismithhisler mismithhisler deleted the b-add-default-max-expressions branch October 17, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants