-
Notifications
You must be signed in to change notification settings - Fork 51
SuperSelect - fix Showcase rich content functionality & disabled option color (HDS-5545)
#3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KristinLBradley
merged 5 commits into
main
from
kristin/hds-5545-super-select-custom-options-issue
Oct 28, 2025
Merged
SuperSelect - fix Showcase rich content functionality & disabled option color (HDS-5545)
#3331
KristinLBradley
merged 5 commits into
main
from
kristin/hds-5545-super-select-custom-options-issue
Oct 28, 2025
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity of Showcase examples
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
It took me awhile to track down the difference between the Showcase examples and the Helios docs example, but it ended up being something really simple... Update: |
KristinLBradley
commented
Oct 27, 2025
.../components/page-components/form/super-select/code-fragments/with-multiple-field-element.gts
Show resolved
Hide resolved
SuperSelect - fix functionality of Showcase Rich content examples (HDS-5545)SuperSelect - fix Showcase Rich content functionality & disabled option color (HDS-5545)
SuperSelect - fix Showcase Rich content functionality & disabled option color (HDS-5545)SuperSelect - fix Showcase rich content functionality & disabled option color (HDS-5545)
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jorytindall
previously approved these changes
Oct 27, 2025
jorytindall
approved these changes
Oct 27, 2025
didoo
approved these changes
Oct 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR:
SuperSelectrich content Showcase example options so that items in the list are selectable, which had been disabled previously.Preview: https://hds-showcase-git-kristin-hds-5545-super-select-6b2f92-hashicorp.vercel.app/components/form/super-select
To test:
Expected: You should be able to select different options from the initially selected ones.
📸 Screenshots
OLD: incorrect disabled options color:

NEW: Disabled option color style restored:

🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.