Skip to content

Conversation

@KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Oct 27, 2025

📌 Summary

If merged, this PR:

  • Enables SuperSelect rich content Showcase example options so that items in the list are selectable, which had been disabled previously.
  • Restores the color style for disabled items in the options list.

Preview: https://hds-showcase-git-kristin-hds-5545-super-select-6b2f92-hashicorp.vercel.app/components/form/super-select

To test:

Expected: You should be able to select different options from the initially selected ones.

📸 Screenshots

OLD: incorrect disabled options color:
image

NEW: Disabled option color style restored:
image

🔗 External links


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 27, 2025 9:39pm
hds-website Ready Ready Preview Oct 27, 2025 9:39pm

@KristinLBradley
Copy link
Contributor Author

KristinLBradley commented Oct 27, 2025

It took me awhile to track down the difference between the Showcase examples and the Helios docs example, but it ended up being something really simple...

Update:
This real issue seems to be with the disabled option color style not working as originally implemented.

@KristinLBradley KristinLBradley marked this pull request as ready for review October 27, 2025 21:09
@KristinLBradley KristinLBradley requested a review from a team as a code owner October 27, 2025 21:09
@KristinLBradley KristinLBradley requested a review from a team October 27, 2025 21:09
@KristinLBradley KristinLBradley changed the title SuperSelect - fix functionality of Showcase Rich content examples (HDS-5545) SuperSelect - fix Showcase Rich content functionality & disabled option color (HDS-5545) Oct 27, 2025
@KristinLBradley KristinLBradley changed the title SuperSelect - fix Showcase Rich content functionality & disabled option color (HDS-5545) SuperSelect - fix Showcase rich content functionality & disabled option color (HDS-5545) Oct 27, 2025
@didoo

This comment was marked as resolved.

@KristinLBradley

This comment was marked as resolved.

jorytindall
jorytindall previously approved these changes Oct 27, 2025
@KristinLBradley KristinLBradley merged commit 90e515c into main Oct 28, 2025
22 of 23 checks passed
@KristinLBradley KristinLBradley deleted the kristin/hds-5545-super-select-custom-options-issue branch October 28, 2025 18:17
@hashibot-hds hashibot-hds mentioned this pull request Oct 28, 2025
@didoo didoo added this to the [email protected] milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants