Skip to content

Conversation

andgen404
Copy link
Contributor

@andgen404 andgen404 commented Oct 6, 2025

📌 Summary

If merged, this PR will fix the nested flush accordion example.

🛠️ Detailed description

During a conversation in Design Review on August 27, we identified an issue with an example in the Accordion guidelines documentation. There is an inaccurate representation of the flush accordion within a container in the Nested Accordion section.

📸 Screenshots

accordion-nesting-do

🔗 External links

Jira ticket: HDS-5425

Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 6, 2025 10:14pm
hds-website Ready Ready Preview Oct 6, 2025 10:14pm

@andgen404 andgen404 marked this pull request as ready for review October 6, 2025 19:29
@andgen404 andgen404 requested review from a team as code owners October 6, 2025 19:29
@jorytindall
Copy link
Contributor

I'm trying to remember back to this conversation, but I don't think this image is correct. I think these are the updates that need to be made based on the image that is live:

  • In the card with nested flush variants: The bottom border for the last nested flush accordion needs to be added
  • The the flush example: the bottom border for the top-level accordion needs to be added and the bottom border for the last nested flush accordion needs to be added.

Somebody else double check me on this, but here's an example from the showcase:
Screenshot 2025-10-06 at 1 31 13 PM

@andgen404
Copy link
Contributor Author

I'm trying to remember back to this conversation, but I don't think this image is correct. I think these are the updates that need to be made based on the image that is live:

  • In the card with nested flush variants: The bottom border for the last nested flush accordion needs to be added
  • The the flush example: the bottom border for the top-level accordion needs to be added and the bottom border for the last nested flush accordion needs to be added.

Somebody else double check me on this, but here's an example from the showcase: Screenshot 2025-10-06 at 1 31 13 PM

Ahh, that jogs my memory on this, I believe you're correct. I went ahead and fixed the example! cc: @hashicorp/hds-design

Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this covers it, but I'd like somebody else to double check to make sure I'm not missing something.

Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this aligns with the showcase examples, which is what we wanted :)

@andgen404 andgen404 merged commit 911159d into main Oct 7, 2025
11 checks passed
@andgen404 andgen404 deleted the website-update-accordion-image branch October 7, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants