Make ember-basic-dropdown a dependency
#3280
Closed
+37
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore
added
release-candidate
📦 RC Packages PublishedLatest commit: e93b70d |
zamoore
changed the title
ember-basic-dropdown a dependency
|
Closed in favor of #3282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR moves
ember-basic-dropdownfrom a dev dependency to a dependency.🛠️ Detailed description
This change addresses a runtime error for consumers of
Hds::Form::SuperSelect. The component relies onember-basic-dropdown, but since it was only adevDependencyin HDS, applications that didn't haveember-basic-dropdowninstalled themselves would encounter a crash. Moving it todependenciesensures it is always available when HDS is installed.To validate the impact of this change, we conducted a spike in Atlas, which uses an older major version of the dependency (
ember-basic-dropdown@^7.3.0). The goal was to ensure that introducing HDS's new dependency onember-basic-dropdown@^8.0.0would not cause build failures or runtime conflicts.The test was successful:
ember dependency-linterrors.Hds::SuperSelect(usingember-basic-dropdown@8via HDS) and existing, direct usages of<BasicDropdown>in Atlas (usingember-basic-dropdown@7) render and function correctly.🔗 External links
Jira ticket: HDS-5273
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.