Remove incorrect HdsCard invocation path
#3275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashibot-hds
added
packages/components
docs-website
didoo
requested changes
Oct 6, 2025
.changeset/seven-windows-crash.md
Outdated
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| Removed the component invocation paths `Hds::Card` and `hds/card`. Consumers must update their templates to use `<Hds::Card::Container>` or `{{hds/card/container}}` |
There was a problem hiding this comment.
The format of this entry should be different: https://hashicorp.atlassian.net/wiki/spaces/HDS/pages/3243114706/Changelog+authoring+best+practices#Component-formatting-for-npm-packages
There was a problem hiding this comment.
Yeah, I guess I didn't consider this as a change to the card component as much as it's a change at the library level. I see that it could be a change directly for Card, though.
zamoore
force-pushed
the
zamoore/hds-5083/remove-incorrect-HdsCard-export
branch
from
2b043ae to
dccb074
Compare
hashibot-hds
removed
docs-website
didoo
approved these changes
Oct 6, 2025
5 tasks
zamoore
added a commit
that referenced
this pull request
Oct 7, 2025
zamoore
added a commit
that referenced
this pull request
Oct 7, 2025
zamoore
added a commit
that referenced
this pull request
Oct 8, 2025
zamoore
added a commit
that referenced
this pull request
Oct 9, 2025
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
zamoore
added a commit
that referenced
this pull request
Oct 13, 2025
zamoore
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will remove the deprecated component invocation paths for the
HdsCardcomponent from the template registry.🔗 External links
Jira ticket: HDS-5083
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.