-
Notifications
You must be signed in to change notification settings - Fork 50
Remove deprecated ember-flight-icon
lazyEmbed
flag
#3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zamoore
merged 2 commits into
main-5.0.0
from
zamoore/hds-4883-remove-ember-flight-icon-lazy-embed
Oct 3, 2025
Merged
Remove deprecated ember-flight-icon
lazyEmbed
flag
#3272
zamoore
merged 2 commits into
main-5.0.0
from
zamoore/hds-4883-remove-ember-flight-icon-lazy-embed
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
approved these changes
Oct 3, 2025
zamoore
added a commit
that referenced
this pull request
Oct 3, 2025
5 tasks
alex-ju
reviewed
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When removing deprecated features, I think we should consider the following:
- How many consumers are still using this feature? (to gauge the impact)
- What upgrade path exists for consumers relying on
emberFlightIcons.lazyEmbed
? (to ensure a solution is available) - How will consumers know how to address this breaking change? (to provide clear documentation)
The answers to these questions should guide the 'how to migrate' instructions in the changelog.
zamoore
added a commit
that referenced
this pull request
Oct 6, 2025
zamoore
added a commit
that referenced
this pull request
Oct 7, 2025
zamoore
added a commit
that referenced
this pull request
Oct 7, 2025
zamoore
added a commit
that referenced
this pull request
Oct 8, 2025
zamoore
added a commit
that referenced
this pull request
Oct 9, 2025
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
zamoore
added a commit
that referenced
this pull request
Oct 13, 2025
zamoore
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will remove support for the deprecated
lazyEmbed
flag forember-flight-icons
in favor of supporting theflightIconsSpriteLazyEmbed
config only.🔗 External links
Jira ticket: HDS-4883
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.