Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Oct 3, 2025

📌 Summary

If merged, this PR will remove support for the deprecated lazyEmbed flag for ember-flight-icons in favor of supporting the flightIconsSpriteLazyEmbed config only.

🔗 External links

Jira ticket: HDS-4883


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 3, 2025 6:50pm
hds-website Ready Ready Preview Oct 3, 2025 6:50pm

@zamoore zamoore merged commit 3851d8f into main-5.0.0 Oct 3, 2025
20 of 21 checks passed
@zamoore zamoore deleted the zamoore/hds-4883-remove-ember-flight-icon-lazy-embed branch October 3, 2025 20:10
@zamoore zamoore mentioned this pull request Oct 3, 2025
5 tasks
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When removing deprecated features, I think we should consider the following:

  • How many consumers are still using this feature? (to gauge the impact)
  • What upgrade path exists for consumers relying on emberFlightIcons.lazyEmbed? (to ensure a solution is available)
  • How will consumers know how to address this breaking change? (to provide clear documentation)

The answers to these questions should guide the 'how to migrate' instructions in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants