Skip to content

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Oct 3, 2025

📌 Summary

If merged, this PR would convert the Reveal showcase page to gts.

🔗 External links

Jira ticket: HDS-5349


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 3, 2025 11:55am
hds-website Ready Ready Preview Oct 3, 2025 11:55am

</HdsAlert>
<p>
<img
src="https://portal.cloud.hashicorp.com/engines-dist/consul/images/aws-subnet-instruction-7c866fcfb753c4794ff07afe5523818c.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src="https://portal.cloud.hashicorp.com/engines-dist/consul/images/aws-subnet-instruction-7c866fcfb753c4794ff07afe5523818c.png"
src="/assets/images/avatar.png"

[Nit] The image link is broken, could replace it with the cat


import { HdsReveal } from '@hashicorp/design-system-components/components';

const RevealIndex: TemplateOnlyComponent = <template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const RevealIndex: TemplateOnlyComponent = <template>
const SubSectionOptions: TemplateOnlyComponent = <template>

[todo] update name

</ShwFlex>
</template>;

export default RevealIndex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default RevealIndex;
export default SubSectionOptions;

[todo] update name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants