-
Notifications
You must be signed in to change notification settings - Fork 50
Showcase: convert Reveal page to gts #3270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
</HdsAlert> | ||
<p> | ||
<img | ||
src="https://portal.cloud.hashicorp.com/engines-dist/consul/images/aws-subnet-instruction-7c866fcfb753c4794ff07afe5523818c.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src="https://portal.cloud.hashicorp.com/engines-dist/consul/images/aws-subnet-instruction-7c866fcfb753c4794ff07afe5523818c.png" | |
src="/assets/images/avatar.png" |
[Nit] The image link is broken, could replace it with the cat
|
||
import { HdsReveal } from '@hashicorp/design-system-components/components'; | ||
|
||
const RevealIndex: TemplateOnlyComponent = <template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const RevealIndex: TemplateOnlyComponent = <template> | |
const SubSectionOptions: TemplateOnlyComponent = <template> |
[todo] update name
</ShwFlex> | ||
</template>; | ||
|
||
export default RevealIndex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default RevealIndex; | |
export default SubSectionOptions; |
[todo] update name
📌 Summary
If merged, this PR would convert the Reveal showcase page to gts.
🔗 External links
Jira ticket: HDS-5349
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.