-
Notifications
You must be signed in to change notification settings - Fork 50
[WIP] [Project Solar / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase #3240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
didoo
wants to merge
18
commits into
project-solar/phase-1/HDS-5505_components/modes-css-compilation
Choose a base branch
from
project-solar/phase-1/HDS-5242_showcase/add-themes-support
base: project-solar/phase-1/HDS-5505_components/modes-css-compilation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
b73dbf9
to
a4f41dd
Compare
a4f41dd
to
cc61972
Compare
519a6a6
to
3863dfa
Compare
cc61972
to
59418c1
Compare
59418c1
to
2f20cdc
Compare
2f20cdc
to
92910be
Compare
92910be
to
a1ff2f5
Compare
…ith `—shw` CSS variables)
…nd be open to configurations
9c14a67
to
386a2c3
Compare
…clusion of pre-compiled (standard and themed) CSS The pre-compiled CSS files have been manually copied in the `public/assets` folder, while waiting to understand what is the best way to proceed to have them added at build time from the `@hashicorp/design-system-components` package
386a2c3
to
31a4eca
Compare
…tion and expand use cases we can cover
…relying on HDS selectors)
31a4eca
to
0bfb69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is a WIP, which contains the porting of previous showcase theming explorations (squashed).
This is based on top of #3259
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.