Modal and Flyout - Improve test coverage (showcase and integration)
#2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
didoo
force-pushed
the
revert-modal-fixes-2846-2902
branch
from
ba2ae3f to
7c9aef3
Compare
…ferent deactivation modes
…o improve coverage
didoo
force-pushed
the
modal-flyout-improve-test-coverage
branch
from
3937940 to
65c1a1a
Compare
didoo
changed the title
Modal and Flyout componentsModal and Flyout - Improve test coverage (showcase and integration)
shleewhite
previously approved these changes
Jun 20, 2025
shleewhite
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR is the second part of #2964 where we add improvements to the test coverage of the
ModalandFlyoutcomponents🛠️ Detailed description
In this PR I have:
ModalandFlyoutadding different deactivation modes of the dialogModalandFlyoutto cover as many use cases as possible🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-4975
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.