Skip to content

Conversation

MelSumner
Copy link
Contributor

📌 Summary

If merged, this PR updates ember-a11y-refocus to v5.0.0.


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@MelSumner MelSumner requested a review from a team as a code owner June 13, 2025 20:41
@MelSumner MelSumner added the dependencies Pull requests that update a dependency file label Jun 13, 2025
Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 13, 2025 8:45pm
hds-website ✅ Ready (Inspect) Visit Preview Jun 13, 2025 8:45pm

@aklkv
Copy link
Collaborator

aklkv commented Jun 13, 2025

as part of v2 upgrade on addon side we might have dropped support for 3.28

@aklkv
Copy link
Collaborator

aklkv commented Jun 13, 2025

while testing this update I also noticed two things:

  • in order to use types we need to move to @glimmer/component v2 otherwise glint is fearking out because addon it self already ueses v2
  • automatic styles inclusion on consumer side has been lost we need to import them manually hds side

@alex-ju
Copy link
Member

alex-ju commented Sep 16, 2025

@MelSumner when time allows, could you try to rebase this – it might be a good candidate for the upcoming major release

@shleewhite shleewhite changed the base branch from main to main-5.0.0 September 24, 2025 15:58
@shleewhite shleewhite closed this Sep 24, 2025
@shleewhite
Copy link
Contributor

Closed in favor of #3234

@aklkv aklkv mentioned this pull request Sep 24, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file packages/components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants