Skip to content

Update ember-stargate to 0.5.0 #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Update ember-stargate to 0.5.0 #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2df307
Update ember-stargate to 0.5.0
RobbieTheWagner Apr 23, 2025
affb977
Create nasty-tools-fold.md
RobbieTheWagner Apr 23, 2025
ad897d1
Remove old comment
RobbieTheWagner Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nasty-tools-fold.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": minor
---

Update ember-stargate to 0.5.0
5 changes: 3 additions & 2 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"ember-get-config": "^2.1.1",
"ember-modifier": "^4.2.0",
"ember-power-select": "^8.6.2",
"ember-stargate": "^0.4.3",
"ember-stargate": "^0.5.0",
"ember-style-modifier": "^4.4.0",
"ember-truth-helpers": "^4.0.3",
"luxon": "^2.3.2 || ^3.4.2",
Expand Down Expand Up @@ -116,7 +116,8 @@
"stylelint-config-rational-order": "^0.1.2",
"stylelint-config-standard-scss": "^14.0.0",
"typescript-eslint": "^8.29.0",
"typescript": "^5.8.2"
"typescript": "^5.8.2",
"webpack": "^5.97.1"
},
"peerDependencies": {
"ember-source": "^3.28.0 || ^4.0.0 || ^5.3.0"
Expand Down
1 change: 0 additions & 1 deletion packages/components/unpublished-development-types/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ declare module '@glint/environment-ember-loose/registry' {
EmbroiderUtilRegistry /*, other addon registries */ {
// local entries
LinkToExternal: typeof LinkTo;
// we have to use `ember-stargate` version `0.4.3` because version `0.5.0` causes a break in the tests for `ember-lts-3.28`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an important reason to not make this change RN

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is correct though. The tests seem to be passing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests may pass in our addon but not in consuming apps. However, if you've tested this in a consuming app that uses 3.28 and found that it still works, please update the comment to be correct but still leave it in. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I can mark this as release candidate and try it in an app on 3.28. Assuming it all works fine, what would you like the comment to say?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed this in nomad and all tests are still passing there as well hashicorp/nomad#25750

I would propose we remove the comment completely, as I don't think it provides any relevant details at this time, but if there is a new comment you would like there, I would be happy to add it, just let me know!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelSumner if the tests are passing, there's no need anymore of the comment (I was the one that added it, and at that time the tests were not passing).

Portal: typeof Portal;
PortalTarget: typeof PortalTarget;
'sort-by': HelperLike<{
Expand Down
5 changes: 3 additions & 2 deletions packages/ember-flight-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
"prettier": "^3.4.2",
"rollup": "^4.28.1",
"rollup-plugin-copy": "^3.5.0",
"typescript": "^5.7.2"
"typescript": "^5.7.2",
"webpack": "^5.97.1"
},
"ember": {
"edition": "octane"
Expand Down Expand Up @@ -105,4 +106,4 @@
"engines": {
"node": ">= 18"
}
}
}
Loading
Loading