-
Notifications
You must be signed in to change notification settings - Fork 50
CodeBlock
- height toggle feature (HDS-4745)
#2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/components/src/styles/components/code-block/index.scss
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
@KristinLBradley Not to throw another option in the ring - but the way the advanced table shadows work is that they are a sibling of the grid and then the height/width are set appropriately and its positioned absolutely on top of the grid. that way if you scroll it always looks correct. |
@shleewhite The issue is that the gradient needs to be a child of the overflowed container, and have We tried placing the gradient as a sibling, and using ![]() |
This comment was marked as resolved.
This comment was marked as resolved.
@KristinLBradley thanks for catching that. I added the |
This comment was marked as resolved.
This comment was marked as resolved.
This issue seems to not be replicable on anyone's instances of Safari, but to those reviewing please test just to double check no one else can replicate this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested more and it seems like the gradient is working well now!
packages/components/src/styles/components/code-block/index.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
📌 Summary
If merged, this PR adds a height toggle control feature for expanding the height of the
CodeBlock
which appears when amaxHeight
value is set that exceeds by the content height.Showcase: https://hds-showcase-git-hds-4745-codeblock-height-toggle-hashicorp.vercel.app/components/code-block#height-limit
📸 Screenshots
Before

After

🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.