Skip to content

Badge: update the color tokens to be more accurate token for the usage #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Badge: update the color tokens to be more accurate token for the usage #2393

merged 1 commit into from
Sep 10, 2024

Conversation

@shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Sep 5, 2024 •
edited
Loading

📌 Summary

If merged, this PR would change the usage of foreground colors in the Badge component as background and border colors to just the palette colors.

📸 Screenshots

Screenshot 2024-09-05 at 1 15 55 PM
Screenshot 2024-09-05 at 1 16 16 PM

🔗 External links

Jira ticket: HDS-3814
Figma file: https://www.figma.com/design/iweq3r2Pi8xiJfD9e6lOhF/%5BWIP%5D-HDS-Components-v2.0?node-id=2-8&t=H85BsHoufgLKUuEk-1

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Sep 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 6, 2024 2:08pm
hds-website ✅ Ready (Inspect) Visit Preview Sep 6, 2024 2:08pm

@shleewhite shleewhite changed the title Badge: update the color tokens to be more accurate token for the usage Badge: update the color tokens to be more accurate token for the usage Sep 5, 2024
@shleewhite shleewhite requested review from a team September 5, 2024 18:18
@shleewhite shleewhite marked this pull request as ready for review September 5, 2024 18:18
@shleewhite shleewhite force-pushed the hds-3814/badge-token-fix branch from 0fe376b to 5e98a2e Compare September 5, 2024 18:32
jorytindall
jorytindall approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution, very nice!

@LilithJames-HDS
Copy link
Contributor

LilithJames-HDS commented Sep 6, 2024

@shleewhite It looks like the grey inverted backgrounds are still mapped to foreground tokens (when inspecting the showcase link). Everything else looks good
Screenshot 2024-09-06 at 9 15 35 AM
Screenshot 2024-09-06 at 9 15 45 AM

@Dhaulagiri Dhaulagiri added this to the [email protected] milestone Sep 6, 2024
@shleewhite shleewhite force-pushed the hds-3814/badge-token-fix branch from 1a75d58 to 046cb41 Compare September 6, 2024 14:04
@shleewhite
Copy link
Contributor Author

shleewhite commented Sep 6, 2024 •
edited
Loading

@shleewhite It looks like the grey inverted backgrounds are still mapped to foreground tokens (when inspecting the showcase link). Everything else looks good

@LilithJames-HDS oops! good catch. should be fixed now.

LilithJames-HDS
LilithJames-HDS approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates so quickly!

alex-ju
alex-ju approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Do we plan to update the BadgeCount as well?

@shleewhite
Copy link
Contributor Author

shleewhite commented Sep 10, 2024

Code looks good! Do we plan to update the BadgeCount as well?

@alex-ju badgecount is already updated and merged!

@alex-ju
Copy link
Member

alex-ju commented Sep 10, 2024

Code looks good! Do we plan to update the BadgeCount as well?

@alex-ju badgecount is already updated and merged!

nice! still playing catch-up 😁

@shleewhite shleewhite merged commit bba9715 into main Sep 10, 2024
@shleewhite shleewhite deleted the hds-3814/badge-token-fix branch September 10, 2024 14:00
@hashibot-hds hashibot-hds mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-ju alex-ju alex-ju approved these changes

@jorytindall jorytindall jorytindall approved these changes

@LilithJames-HDS LilithJames-HDS LilithJames-HDS approved these changes

Assignees

No one assigned

Labels

packages/components

Projects

None yet

Milestone

[email protected]

Development

Successfully merging this pull request may close these issues.

6 participants

@shleewhite @LilithJames-HDS @alex-ju @jorytindall @Dhaulagiri @hashibot-hds