BadgeCount: update the color tokens to be more accurate token for the usage
#2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jorytindall
approved these changes
Sep 5, 2024
Contributor
jorytindall
left a comment
jorytindall
left a comment
There was a problem hiding this comment.
Good for me, but would also be good to get some quick eyes from @LilithJames-HDS
LilithJames-HDS
approved these changes
Sep 6, 2024
Contributor
LilithJames-HDS
left a comment
LilithJames-HDS
left a comment
There was a problem hiding this comment.
This looks great, thanks so much!
KristinLBradley
approved these changes
Sep 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would change the usage of foreground colors in the
BadgeCountcomponent as background and border colors to just the palette colors.📸 Screenshots
🔗 External links
Jira ticket: HDS-3817
Figma file: https://www.figma.com/design/iweq3r2Pi8xiJfD9e6lOhF/%5BWIP%5D-HDS-Components-v2.0?node-id=205-564&t=16lLFxX1rGve3Zqp-1
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.