Skip to content

Conversation

@KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Aug 22, 2024

📌 Summary

If merged, this PR adds additional scoping to dark theme styles for Button & Dropdown components within the SideNav & AppHeader so when nested within a Dropdown they will not inherit the dark theme.

🛠️ Detailed description

Included changes:

  • Scoped styles to apply dark theme styling to Buttons and Dropdowns within SideNav & AppHeader only when they are not nested within another Dropdown
  • Added Showcase examples of Button & Dropdown nested within another Dropdown within SideNav & AppHeader

📸 Screenshots

SIDE-NAV NESTED ELEMENTS

image

APP-HEADER NESTED ELMENTS

image

🔗 External links


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 23, 2024 8:14pm
hds-website ✅ Ready (Inspect) Visit Preview Aug 23, 2024 8:14pm

@KristinLBradley KristinLBradley marked this pull request as ready for review August 22, 2024 21:34
@KristinLBradley KristinLBradley requested review from a team and alex-ju August 22, 2024 21:34
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a pragmatic solution. Would you be able to test this in Vault to make sure we're addressing their issue? (just read your comments in Slack).

And don't forget to add a changelog entry for this fix

Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KristinLBradley
Copy link
Contributor Author

I think this is a pragmatic solution. Would you be able to test this in Vault to make sure we're addressing their issue? (just read your comments in Slack).

And don't forget to add a changelog entry for this fix

Unfortunately, this will not resolve their particular issue as they used custom components with custom styling for their dropdown and buttons within the SideNav. However, if they update their code to use HDS components in the future it will fix the issue. So while this update will not fix Vault's immediate issue on its own, it will prevent similar issues for other product teams (as long as they use HDS components) and it will help the Vault team if they update their code in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants