-
Notifications
You must be signed in to change notification settings - Fork 51
Enterprise Nav: SideNav & AppHeader—Improve scoping for dark theme styling
#2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enterprise Nav: SideNav & AppHeader—Improve scoping for dark theme styling
#2359
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a pragmatic solution. Would you be able to test this in Vault to make sure we're addressing their issue? (just read your comments in Slack).
And don't forget to add a changelog entry for this fix
shleewhite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Unfortunately, this will not resolve their particular issue as they used custom components with custom styling for their dropdown and buttons within the SideNav. However, if they update their code to use HDS components in the future it will fix the issue. So while this update will not fix Vault's immediate issue on its own, it will prevent similar issues for other product teams (as long as they use HDS components) and it will help the Vault team if they update their code in the future. |
6cda932 to
a596f28
Compare
📌 Summary
If merged, this PR adds additional scoping to dark theme styles for
Button&Dropdowncomponents within theSideNav&AppHeaderso when nested within a Dropdown they will not inherit the dark theme.🛠️ Detailed description
Included changes:
📸 Screenshots
SIDE-NAV NESTED ELEMENTS
APP-HEADER NESTED ELMENTS
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.