Convert SuperSelect components to TypeScript
#2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-ju
force-pushed
the
alex-ju/typescript-super-select
branch
from
71d6a26 to
c9c0b58
Compare
shleewhite
reviewed
Aug 22, 2024
Contributor
shleewhite
left a comment
shleewhite
left a comment
There was a problem hiding this comment.
Mostly questions! Couple of small things and I think you need to add an export to the components.ts file.
packages/components/src/components/hds/form/super-select/single/base.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/form/super-select/multiple/base.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/form/super-select/multiple/base.ts
Show resolved
Hide resolved
packages/components/src/components/hds/form/super-select/multiple/field.hbs
Show resolved
Hide resolved
packages/components/src/components/hds/form/super-select/single/field.hbs
Show resolved
Hide resolved
alex-ju
force-pushed
the
alex-ju/typescript-super-select
branch
from
a34a665 to
08c99af
Compare
shleewhite
approved these changes
Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Convert
SuperSelectcomponents to TypeScript🛠️ Detailed description
SuperSelect::Singlecomponents to TypeScriptSuperSelect::Multiplecomponents to TypeScriptNotable changes:
PowerSelectComponentclass to using thepublicAPI(this is because we now need to extend the glimmerComponent; it also makes more sense to uncouple the classes and use the API instead)SuperSelect::Single(changed fromresultstototalas per design)🔗 External links
Jira ticket: HDS-2723
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.