SideNav - Deprecate SideNav::Header::IconButton (HDS-3770 )
#2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
force-pushed
the
hds-3770-deprecate-sidenav-iconbutton
branch
from
38b0727 to
0be0cb9
Compare
hashibot-hds
added
packages/components
docs-website
KristinLBradley
commented
Aug 27, 2024
| url: 'https://helios.hashicorp.design/components/side-nav?tab=version%20history#480', // TODO: Confirm URL | ||
| for: '@hashicorp/design-system-components', | ||
| since: { | ||
| enabled: '4.9.0', // TODO: Confirm version |
Contributor
Author
There was a problem hiding this comment.
What should I do for the above version numbers and url? Would I edit later shortly before release? (Since I'm not sure what they should be?)
Collaborator
There was a problem hiding this comment.
Seems safe to assume this will land in 4.10 as part of #2330
Collaborator
There was a problem hiding this comment.
But we can always change it directly in the release branch if we need to. Same with the URL, but you could assume it would be https://helios.hashicorp.design/components/side-nav?tab=version%20history#4100 for now
Contributor
Author
There was a problem hiding this comment.
Ok, thank you!
KristinLBradley
changed the title
SideNav - Deprecate SideNav::Header::IconButton (HDS-3770 )SideNav - Deprecate SideNav::Header::IconButton (HDS-3770 )
Contributor
Author
|
Let me know if there's anything I missed in marking this as "deprecated". |
KristinLBradley
force-pushed
the
hds-3770-deprecate-sidenav-iconbutton
branch
from
00ca549 to
f1204ef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
shleewhite
reviewed
Aug 29, 2024
Dhaulagiri
reviewed
Sep 3, 2024
website/docs/components/side-nav/partials/version-history/4.10.0.md
Outdated
Show resolved
Hide resolved
….0.md Co-authored-by: Brian Runnells <[email protected]>
Co-authored-by: Cristiano Rastelli <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will deprecate the
Hds::SideNav::Header::IconButtoncomponent.Previews:
🛠️ Detailed description
👉 Related reference on deprecating an HDS component or feature
Included changes:
IconButtonEmber component in code:Hds::SideNav::Header::IconButtonwithHds::Button.IconButton🔗 External links
Jira ticket: HDS-3770
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.