add explicit ember-get-config depedency #2283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
commented
Jul 26, 2024
zamoore
approved these changes
Jul 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Adds an explicit reference to a dependency used in the icon initializer
🛠️ Detailed description
Running the website I noticed this warning
#2198 added this logic to the components package without explicitly referencing the
ember-get-configdependency that is used here. Similar to #2169, we need to explicitly depend on it to avoid issues (even though I would imagine it's always going to exist somewhere in the dependency tree anyhow).💬 Please consider using conventional comments when reviewing this PR.