ApplicationState Enhancements - Implementation
#2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zamoore
force-pushed
the
FEATURE-HDS-3542-ApplicationState-Code
branch
from
315a271 to
184f6bc
Compare
didoo
requested changes
Jul 25, 2024
There was a problem hiding this comment.
@zamoore I did a first pass, there are things that need to be fixed.
I haven't reviewed yet the actions alignments (there's something not working for me, not sure if it's at design level /cc @majedelass) and the vertical spacing, I'll do it in the second pass.
packages/components/src/components/hds/application-state/header.hbs
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/application-state/header.hbs
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/application-state/header.hbs
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/application-state/index.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/application-state/index.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/application-state/media.ts
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/application-state/index-test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Cristiano Rastelli <[email protected]>
zamoore
force-pushed
the
FEATURE-HDS-3542-ApplicationState-Code
branch
from
5c1b537 to
4cda0d6
Compare
didoo
approved these changes
Aug 1, 2024
Co-authored-by: Cristiano Rastelli <[email protected]>
Co-authored-by: Zack Moore <[email protected]> Co-authored-by: Kristin Bradley <[email protected]> Co-authored-by: Jory Tindall <[email protected]> Co-authored-by: Cristiano Rastelli <[email protected]> Co-authored-by: Cristiano Rastelli <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR updates the design and functionality of the
ApplicationStatecomponent.🛠️ Detailed description
Mediachild component that takes no arguments. Yields to any content.align(leftorcenter) argument that changes the orientation of content480px.DropdownandButtonas actions📸 Screenshots
New default layout for existing
ApplicationStateimplementations without mediaApplicationStatewithout media, new alignment optionsApplicationStatewith media, new alignment optionsApplicationStatewith extra-wide media, new alignment options🔗 External links
Jira ticket: HDS-3542
Figma file: Figma
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.