Extend the "Button" component to support also links as actions (02)

packages/components/addon/components/hds/button/index.hbs

@@ -1,4 +1,16 @@
-<button class={{this.classNames}} ...attributes aria-label={{if this.isIconOnly this.text null}} type={{this.type}}>
+<Hds::Interactive
+  class={{this.classNames}}
+  @current-when={{@current-when}}
+  @models={{hds-link-to-models @model @models}}
+  @query={{hds-link-to-query @query}}
+  @replace={{@replace}}
+  @route={{@route}}
+  @isRouteExternal={{@isRouteExternal}}
+  @href={{@href}}
+  @isHrefExternal={{@isHrefExternal}}
+  ...attributes
+  aria-label={{if this.isIconOnly this.text null}}
+>
   {{#if this.isIconOnly}}
     <div class="hds-button__icon">
       <FlightIcon @name={{this.icon}} @size={{this.iconSize}} @stretched={{true}} />
@@ -26,4 +38,4 @@
       </div>
     {{/if}}
   {{/if}}
-</button>
+</Hds::Interactive>

packages/components/addon/components/hds/button/index.js

@@ -3,11 +3,9 @@ import { assert } from '@ember/debug';
 
 export const DEFAULT_SIZE = 'medium';
 export const DEFAULT_COLOR = 'primary';
-export const DEFAULT_TYPE = 'button';
 export const DEFAULT_ICONPOSITION = 'leading';
 export const SIZES = ['small', 'medium', 'large'];
 export const COLORS = ['primary', 'secondary', 'tertiary', 'critical'];
-export const TYPES = ['button', 'submit', 'reset'];
 export const ICONPOSITIONS = ['leading', 'trailing'];
 
 export default class HdsButtonIndexComponent extends Component {
@@ -126,25 +124,6 @@ export default class HdsButtonIndexComponent extends Component {
     }
   }
 
-  /**
-   * @param type
-   * @type {string}
-   * @default button
-   * @description The value for the button's `type` attribute. Acceptable values are `button`, `submit`, and `reset`
-   */
-  get type() {
-    let { type = DEFAULT_TYPE } = this.args;
-
-    assert(
-      `@type for "Hds::Button" must be one of the following: ${TYPES.join(
-        ', '
-      )}; received: ${type}`,
-      TYPES.includes(type)
-    );
-
-    return type;
-  }
-
   /**
    * @param isFullWidth
    * @type {boolean}

packages/components/addon/components/hds/interactive/index.hbs

@@ -26,11 +26,11 @@
   {{! IMPORTANT: we can't support the direct use of the "href" HTML attribute via ...attributes, because we need to rely on the "@href" Ember argument to differentiate between different types of generated output }}
 {{else if @href}}
   {{#if this.isHrefExternal}}
-    <a target="_blank" rel="noopener noreferrer" ...attributes href={{@href}}>
+    <a target="_blank" rel="noopener noreferrer" ...attributes href={{@href}} {{on "keyup" this.onKeyUp}}>
       {{yield}}
     </a>
   {{else}}
-    <a ...attributes href={{@href}}>
+    <a ...attributes href={{@href}} {{on "keyup" this.onKeyUp}}>
       {{yield}}
     </a>
   {{/if}}

packages/components/addon/components/hds/interactive/index.js

@@ -1,4 +1,5 @@
 import Component from '@glimmer/component';
+import { action } from '@ember/object';
 
 export default class HdsInteractiveComponent extends Component {
   /**
@@ -22,4 +23,11 @@ export default class HdsInteractiveComponent extends Component {
   get isRouteExternal() {
     return this.args.isRouteExternal ?? false;
   }
+
+  @action
+  onKeyUp(event) {
+    if (event.key === ' ' || event.code === 'Space') {
+      event.target.click();
+    }
+  }
 }

packages/components/app/styles/components/button.scss

@@ -26,6 +26,11 @@ $hds-button-focus-border-width: 3px;
   position: relative;
   width: auto;
 
+  // the <a> element behaves differently than a <button>
+  @at-root a#{&} {
+    width: fit-content;
+  }
+
   // This covers all of the browsers and focus scenarios (due to the custom focus design).
   &:disabled,
   &[disabled],
@@ -304,4 +309,24 @@ $size-props: (
       border-color: transparent;
     }
   }
+}
+
+
+// SPECIAL
+
+// we apply a visual treatment to alert the developer if a "href" HTML attribute is used (instead of the "@href" Ember argument)
+
+button.hds-button[href] {
+  background-color: red !important;
+  color: white !important;
+  border: none;
+
+  .hds-button__text,
+  &::before {
+    display: none;
+  }
+
+  &::after {
+    content: ' Attention: you’re passing a "href" attribute to the "Hds::Button" component, you should use an "@href" argument.';
+  }
 }

packages/components/package.json

@@ -42,7 +42,8 @@
     "ember-cli-sass": "^10.0.1",
     "ember-keyboard": "^8.1.0",
     "ember-named-blocks-polyfill": "^0.2.5",
-    "sass": "^1.43.4"
+    "sass": "^1.43.4",
+    "sinon": "^14.0.0"
   },
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",

packages/components/tests/dummy/app/styles/pages/db-button.scss

@@ -18,6 +18,12 @@
     width: 300px;
 }
 
+.dummy-button-generated-list {
+    display: flex;
+    flex-wrap: wrap;
+    gap: 1rem;
+}
+
 .dummy-button-states-grid {
     display: grid;
     grid-gap: 0.5rem;