Skip to content

feat(showcase): glint#2116

Merged
aklkv merged 4 commits intofeat/showcase-ts-toolingfrom
feat/glint-showcase
May 20, 2024
Merged

feat(showcase): glint#2116
aklkv merged 4 commits intofeat/showcase-ts-toolingfrom
feat/glint-showcase

Conversation

@aklkv
Copy link
Copy Markdown
Collaborator

@aklkv aklkv commented May 18, 2024

📌 Summary

  • add glint patch
  • enable glint type checking by removing @glint-nocheck from all route templates
  • bump ember-page-title as the previous version did not expose the correct types

🛠️ Detailed description

📸 Screenshots

🔗 External links

Related upstream PR: typed-ember/glint#721


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@aklkv aklkv requested review from alex-ju and natmegs May 18, 2024 04:15
@aklkv aklkv self-assigned this May 18, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 19, 2024 10:18pm
hds-website ✅ Ready (Inspect) Visit Preview May 19, 2024 10:18pm

Copy link
Copy Markdown
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@aklkv aklkv merged commit c712c3f into feat/showcase-ts-tooling May 20, 2024
@aklkv aklkv deleted the feat/glint-showcase branch May 20, 2024 21:55
@aklkv aklkv restored the feat/glint-showcase branch May 20, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants