hbs: update comment to remove line break #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template languages that generate HTML files, like Handlebars, are often sensitive to whitespace, so adding a line break may change how a page is rendered. This commit adds a `~` at the end of the comment as a whitespace control so the rendering engine removes the additional line break added by the license header comment.
dlaguerta
approved these changes
Apr 13, 2023
|
This change seems to be making Babel parser unhappy in Cloud UI so we needed to tweak the Design System code to remove the trailing tilde coming from automation. Is it possible that the whitespace management syntax is not valid for comments? 🤔 In #16861 I can see you have an explicit new line after each comment; would removing that space achieve a similar outcome? |
|
We're seeing the same thing in Vault that @alex-ju reported after the license headers were recently updated. It looks like there is an open issue related to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Template languages that generate HTML files, like Handlebars, are often sensitive to whitespace, so adding a line break may change how a page is rendered.
This commit adds a
~at the end of the comment as a whitespace control so the rendering engine removes the additional line break added by the license header comment.🔗 External Links
RELPLAT-703
👍 Definition of Done
🤔 Can be merged upon approval?
✅