Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX-Copyright-Text tag #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adam-moss
Copy link

Signed-off-by: Adam Moss [email protected]

🛠️ Description

Prefix the copyright text with SPDX-FileCopyrightText. This allows for easier machine parser of spdx data.

As a by-product of this it has highlight a bunch of extra files missing headers due to containing the word copyright.

I've updated the .pre-commit-config.yaml too.

🔗 External Links

https://spdx.github.io/spdx-spec/v2.3/file-tags/#h2-file-tags-format

👍 Definition of Done

  • New functionality works?
  • Tests added?

🤔 Can be merged upon approval?

✅ It can, but there is an issue remaining that if the copyright text itself is change or entered incorrectly in a file (i.e. a line SPDX-FileCopyrightText: bla) the tool does not pick this up as an error.

@adam-moss adam-moss requested a review from a team February 13, 2023 19:28
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

@jeffwecan jeffwecan removed the request for review from a team October 18, 2023 15:07
Prefix the copyright text with SPDX-FileCopyrightText to allow for
easier machine parser of SPDX data.

Closes hashicorp#39

Signed-off-by: Adam Moss <[email protected]>
@adam-moss adam-moss requested review from a team, shore and randyhdev and removed request for a team November 13, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants