Skip to content

Update Ports Documentation #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schristoff merged 1 commit into from
Apr 5, 2019
Merged

Update Ports Documentation #5609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions website/source/docs/agent/options.html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,8 @@ port.

* DNS Interface (Default 8600). Used to resolve DNS queries. TCP and UDP.

* gRPC API (Default 8302). Currently gRPC is only used to expose Envoy xDS API to Envoy proxies.
Copy link
Contributor

@pearkes pearkes Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gRPC port recommends 8502, sort there is sort-of a default, but not truly. I guess given that we should also say that it is only if configured?

Copy link
Contributor

@banks banks Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'd suggest something like:

 * gRPC API (Optional, Defaults to 8502 in `-dev` mode). Currently gRPC is only used to expose the xDS API to Envoy proxies. It is off by default but port 8502 is a convention used by various tools as the default.

Should we also consider adding HTTPS here? It's in the same boat - off by default so there is no actual default but we recommend 8501 for consistency across tools etc.

Copy link
Contributor

@banks banks Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed this was merged already


## <a id="reloadable-configuration"></a>Reloadable Configuration

Reloading configuration does not reload all configuration items. The
Expand Down