Backport of metadata: memoize the parsed build versions into release/1.20.x#22118
Merged
rboyer merged 4 commits intorelease/1.20.xfrom Feb 5, 2025
Conversation
hc-github-team-consul-core
force-pushed
the
backport/rboyer/memoize-build-version/seriously-primary-narwhal
branch
from
8dd62d6 to
561d2cc
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 3, 2025
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
rboyer
approved these changes
Feb 5, 2025
rboyer
deleted the
backport/rboyer/memoize-build-version/seriously-primary-narwhal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22113 to be assessed for backporting due to the inclusion of the label backport/1.20.
The below text is copied from the body of the original PR.
Description
There will only be a small set of consul build versions that a single consul server will witness. Inside of
metadata.IsConsulServerwe use a very expensive function in thehashicorp/go-versionlibrary to parse these into read-only*version.Versionstructs all over Consul.Memoize these in a package cache map. Likely the thing will only have like 2 keys in it ever over the life of the process.
Overview of commits