Adds docs to upgrade-specific page to include the removal of the depr…#20844
Merged
missylbytes merged 5 commits intomainfrom Mar 26, 2024
Merged
Conversation
github-actions
bot
added
the
type/docs
missylbytes
requested review from
a team,
andrewstucki and
nathancoleman
and removed request for
a team
Merged
4 tasks
Contributor
jkirschner-hashicorp
left a comment
jkirschner-hashicorp
left a comment
There was a problem hiding this comment.
Left a few suggestions. Thanks for working on this!
|
|
||
| As of Consul v1.19, Consul does not emit the redundant metric with the double `consul.consul` in its name. Any monitoring alerts and dashboards that you may have utilizing these metrics may require edits to update to the simplified metric name. | ||
|
|
||
| ### Legacy API Gateway Removal |
Contributor
There was a problem hiding this comment.
We should remove the no-longer-existing stanza from the Helm chart docs: https://developer.hashicorp.com/consul/docs/k8s/helm#v-apigateway
Contributor
|
Related to this update: #20857 |
…ecated API Gateway stanza for 1.19
missylbytes
force-pushed
the
net-6263-update-upgrade-specific-docs-for-legacy-apigw-removal
branch
from
c854142 to
0236561
Compare
Co-authored-by: Jared Kirschner <85913323+jkirschner-hashicorp@users.noreply.github.com>
nathancoleman
added
the
pr/no-changelog
nathancoleman
requested changes
Mar 21, 2024
Member
nathancoleman
left a comment
nathancoleman
left a comment
There was a problem hiding this comment.
Thanks for knocking this out! Just one thing that I noticed
…gacy-apigw-removal
sophie-gairo
approved these changes
Mar 26, 2024
nathancoleman
approved these changes
Mar 26, 2024
missylbytes
deleted the
net-6263-update-upgrade-specific-docs-for-legacy-apigw-removal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ecated API Gateway stanza for 1.19
Description
The Legacy API Gateway that was deprecated in 1.16.0 is being removed in 1.19.0. This PR adds this to the upgrade-specific page for
1.19.0.Links
The PR for removing it from k8s: hashicorp/consul-k8s#3718
Helm chart reference page to see apiGateway removed: https://consul-rfmx0h0qi-hashicorp.vercel.app/consul/docs/k8s/helm
Upgrade-specific docs: https://consul-rfmx0h0qi-hashicorp.vercel.app/consul/docs/upgrading/upgrade-specific
PR Checklist