Manual backport of [NET-6741] make: Add target for updating dependencies across all modules into release/1.15.x#20687
Merged
zalimeni merged 2 commits intorelease/1.15.xfrom Feb 27, 2024
Conversation
Update go-mod-tidy Make target to use flexible modules list. This will update the list to include envoyextensions and troubleshoot.
zalimeni
added
pr/no-changelog
4 tasks
zalimeni
commented
Feb 21, 2024
| GOLANGCI_LINT_VERSION='v1.55.2' | ||
| MOCKERY_VERSION='v2.20.0' | ||
| BUF_VERSION='v1.4.0' | ||
|
|
Member
Author
There was a problem hiding this comment.
Propagated from later branches intentionally to aid future backports.
4 tasks
rboyer
approved these changes
Feb 27, 2024
zalimeni
deleted the
backport/zalimeni/net-6741-add-make-target-dependency-update-modules-1.15
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19785 which also includes updates to Go modules list / Make target from #17462 (landed on
mainduring 1.16).Asking for a quick extra review bc @rboyer 's original
go-mod-tidyintroduction noted "the correct order" and I wanted to make sure this wasn't sneakily risky in 1.15.Testing & Reproduction steps
Tested locally as in original PR, same results.
PR Checklist
Overview of commits