Fix to not create a watch to Internal.ServiceDump when mesh gateway is not used#20168
Merged
hashi-derek merged 13 commits intomainfrom Jan 18, 2024
Merged
Fix to not create a watch to Internal.ServiceDump when mesh gateway is not used#20168hashi-derek merged 13 commits intomainfrom
Internal.ServiceDump when mesh gateway is not used#20168hashi-derek merged 13 commits intomainfrom
Conversation
added 8 commits
January 11, 2024 10:41
Only skip watching gateways when target is not peered
…ways. do not prevent remote gateway watch from being created when a local one exist as both are different.
hashi-derek
approved these changes
Jan 12, 2024
Contributor
hashi-derek
left a comment
There was a problem hiding this comment.
Excellent catch. Thank you for tracking this down and fixing it.
erichaberkorn
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
Collaborator
|
@dhiaayachi, a backport is missing for this PR [20168] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description: |
4 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This add a fix to properly verify the gateway mode before creating a watch specific to mesh gateways. This watch have a high performance cost and when mesh gateways are not used is not used.
This also adds an optimization to only return the nodes when watching the
Internal.ServiceDumpRPC to avoid unnecessary disco chain compilation. As watches in proxy config only need the nodes.Testing & Reproduction steps
Added a test to create a set of services with mesh gateway mode default and expecting that this watch is not effective.
Links
PR Checklist