NET-7178: add workload selector to MeshGateway protobuf definition#20159
NET-7178: add workload selector to MeshGateway protobuf definition#20159
Conversation
0fc7c92 to
5279d92
Compare
There was a problem hiding this comment.
Hmm based on Nathan's comment here, I think you might need to break this out so it doesn't show up on the CRD. I couldn't find a kubetag that ignores a field completely, but it does look like you can set it to ignore unexported fields
There was a problem hiding this comment.
Does that mean we would need to add the ignore option on the controller-gen command itself?
There was a problem hiding this comment.
I also couldn't find an option to ignore a single field; however, we paired as a group earlier today and worked through omitting the field in the consul-k8s CRD. We'll just use a different parent struct for the CRD in consul-k8s and then map that to a MeshGateway defined here by adding a workload selector before syncing into consul
e50a15a to
864cef5
Compare
8f2e796 to
2472ac2
Compare
nathancoleman
left a comment
There was a problem hiding this comment.
Nice work! Some optional commentary below but fine with this merging
There was a problem hiding this comment.
Stole the second line from other usages of this type across consul
| // Selection of workloads to be exposed through the MeshGateway | |
| // Selection of workloads to be configured as mesh gateways. | |
| // These can be prefixes or specific workload names. |
There was a problem hiding this comment.
I also couldn't find an option to ignore a single field; however, we paired as a group earlier today and worked through omitting the field in the consul-k8s CRD. We'll just use a different parent struct for the CRD in consul-k8s and then map that to a MeshGateway defined here by adding a workload selector before syncing into consul
8283f73 to
4d3cc05
Compare
Description
This PR updates the MeshGateway protobuf definition to include workload selector. Another PR in Consul-K8s will build upon this to use this field but not add it to the meshgateway CRD
Testing & Reproduction steps
UI test passes
No linting errors
MeshGateway struct updates only. Validate the fields are updated correctly and CI/Lint pass
Links
PR Checklist