NET-6942 - Replace usage of deprecated Envoy field envoy.config.cluster.v3.Cluster.http_protocol_options.#20010
Merged
NET-6942 - Replace usage of deprecated Envoy field envoy.config.cluster.v3.Cluster.http_protocol_options.#20010
Conversation
jmurret
added
backport/1.15
github-actions
bot
added
the
theme/cli
…er.v3.Cluster.http_protocol_options.
zalimeni
approved these changes
Dec 21, 2023
Member
zalimeni
left a comment
zalimeni
left a comment
There was a problem hiding this comment.
Two minor things but otherwise LGTM, approved pending any fixups
Comment on lines
+657
to
+663
| "envoy.extensions.upstreams.http.v3.HttpProtocolOptions": { | ||
| "@type": "type.googleapis.com/envoy.extensions.upstreams.http.v3.HttpProtocolOptions", | ||
| "explicit_http_config": { | ||
| "http_protocol_options": {} | ||
| } | ||
| } | ||
| }, |
Member
There was a problem hiding this comment.
~~ Here and below, indent looks weird to me - seems like maybe a mix of tabs and spaces?
Comment on lines
+53
to
+55
| //if t.Failed() { | ||
| runCmd(t, "capture_logs", caseDir) | ||
| //} |
This was referenced Dec 21, 2023
4 tasks
This was referenced Dec 21, 2023
jmurret
added a commit
that referenced
this pull request
Dec 21, 2023
…er.v3.Cluster.http_protocol_options. (#20010) * NET-6942 - Replace usage of deprecated Envoy field envoy.config.cluster.v3.Cluster.http_protocol_options. * add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
PR Checklist