Remove V2 PeerName field from pbresource.Tenancy#19865
Merged
Conversation
github-actions
bot
added
type/docs
mkeeler
added
pr/no-changelog
boruszak
approved these changes
Dec 8, 2023
Contributor
boruszak
left a comment
boruszak
left a comment
There was a problem hiding this comment.
From the docs perspective, there's only one page edited, so I'm approving with a LGTM so you're not blocked.
BUT: that page lists a -peer flag for the command. Does this flag still work after removing the PeerName field? If not we should remove that flag's listing on the page as well.
mkeeler
force-pushed
the
remove-v2-peername
branch
from
0475e96 to
fdeb521
Compare
Member
Author
|
@boruszak I went ahead and removed other mentions of the -peer cli command from the docs. |
mkeeler
force-pushed
the
remove-v2-peername
branch
from
fb18055 to
51ffae0
Compare
dhiaayachi
approved these changes
Dec 15, 2023
Contributor
dhiaayachi
left a comment
dhiaayachi
left a comment
There was a problem hiding this comment.
LGTM!
@mkeeler I resolved the conflicts on this, I hope that's fine 😅
I think we should merge this ASAP before it conflict again
mkeeler
force-pushed
the
remove-v2-peername
branch
from
d734cd6 to
c963192
Compare
mkeeler
force-pushed
the
remove-v2-peername
branch
from
c963192 to
e5b9276
Compare
mkeeler
force-pushed
the
remove-v2-peername
branch
from
e5b9276 to
b3f44ea
Compare
mkeeler
force-pushed
the
remove-v2-peername
branch
from
b3f44ea to
09355b1
Compare
mkeeler
force-pushed
the
remove-v2-peername
branch
from
09355b1 to
664ba5f
Compare
mkeeler
force-pushed
the
remove-v2-peername
branch
from
664ba5f to
19b6a1e
Compare
The peer name will eventually show up elsewhere in the resource. For now though this rips it out of where we don’t want it to be.
mkeeler
force-pushed
the
remove-v2-peername
branch
from
19b6a1e to
01750f7
Compare
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The peer name will eventually show up elsewhere in the resource. For now though this rips it out of where we don’t want it to be.
Testing & Reproduction steps
All existing tests should pass