Backport of [NET-5688] APIGateway UI Topology Fixes into release/1.15.x#19761
Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
Closed
Conversation
558d2d1 to
6e60456
Compare
6e60456 to
558d2d1
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 28, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19657 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@jm96441n
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
After the move to the native consul api gateways, the UI topology view around API gateways was broken in that API Gateways would just not show in the view.
Testing & Reproduction steps
make dev-dockerfrom consulmake startfrom thek8s/basic-gwdirectorylocalhost:8501and view the service/gateway topology views to see the missing partsmake dev-dockerctrl-con the example where port-forwarding is running, then runmake reload, this will reinstall consul with the new changeslocalhost:8051again to see the topology views with the api gateway presentLinks
PR Checklist
Overview of commits