Skip to content

Backport of [NET-5688] APIGateway UI Topology Fixes into release/1.15.x#19761

Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
backport/NET-5688-gwui-fixes/mentally-superb-prawn
Closed

Backport of [NET-5688] APIGateway UI Topology Fixes into release/1.15.x#19761
hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
backport/NET-5688-gwui-fixes/mentally-superb-prawn

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19657 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jm96441n
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

After the move to the native consul api gateways, the UI topology view around API gateways was broken in that API Gateways would just not show in the view.

image
image

Testing & Reproduction steps

  1. Compile a local version of consul without these changes using make dev-docker from consul
  2. clone https://github.com/hashicorp/shared-consul-examples/ and run make start from the k8s/basic-gw directory
  3. this will setup a port forward, in your browser visit localhost:8501 and view the service/gateway topology views to see the missing parts
  4. switch to this branch in the consul repo and re-run make dev-docker
  5. use ctrl-c on the example where port-forwarding is running, then run make reload, this will reinstall consul with the new changes
  6. go to localhost:8051 again to see the topology views with the api gateway present

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-5688-gwui-fixes/mentally-superb-prawn branch 2 times, most recently from 558d2d1 to 6e60456 Compare November 28, 2023 21:27
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-5688-gwui-fixes/mentally-superb-prawn branch from 6e60456 to 558d2d1 Compare November 28, 2023 21:27
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul November 28, 2023 21:33 Inactive
@jm96441n jm96441n closed this Nov 28, 2023
@github-actions github-actions bot deleted the backport/NET-5688-gwui-fixes/mentally-superb-prawn branch August 29, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants