Backport of fix a panic in the CLI when deleting an acl policy with an unknown name into release/1.17.x by hc-github-team-consul-core · Pull Request #19692 · hashicorp/consul

hc-github-team-consul-core · 2023-11-20T14:48:19Z

Backport

This PR is auto-generated from #19679 to be assessed for backporting due to the inclusion of the label backport/1.17.

The below text is copied from the body of the original PR.

Description

This fix a panic in the CLI when deleting a policy using its name and that name do not exist on the server.

consul acl policy delete -namespace david-test -datacenter us-east-infra -name namespace-management

panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1012db5]




goroutine 1 [running]:

github.com/hashicorp/consul/command/acl.GetPolicyIDByName(...)

/Users/dayachi/git/consul-enterprise/command/acl/acl_helpers.go:102

github.com/hashicorp/consul/command/acl/policy/delete.(*cmd).Run(0xc000d62050, {0xc000072180?, 0xffffffffffffffff?, 0x0?})

/Users/dayachi/git/consul-enterprise/command/acl/policy/delete/policy_delete.go:62 +0x155

github.com/mitchellh/cli.(*CLI).Run(0xc000fa3400)

/Users/dayachi/go/pkg/mod/github.com/mitchellh/cli@v1.1.5/cli.go:262 +0x5b8

main.realMain()

/Users/dayachi/git/consul-enterprise/main.go:48 +0x469

main.main()

/Users/dayachi/git/consul-enterprise/main.go:18 +0x13

root@hashi-i-0cb3233c55d0fe848:/opt/consul/1.15.6+debug# consul version

Consul v1.15.6+ent

Revision ba04dc46b8+CHANGES

Build Date 2023-09-19T23:47:29Z

Protocol 2 spoken by default, understands 2 to 3 (agent will automatically use protocol >2 when speaking to compatible agents)

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern

Overview of commits

e07f4da - eecf61b

Update version file to 1.18-dev, and replace 1.13 nightly test with 1.17.

This change adds ACL hooks to the remaining catalog and mesh resources, excluding any computed ones. Those will for now continue using the default operator:x permissions. It refactors a lot of the common testing functions so that they can be re-used between resources. There are also some types that we don't yet support (e.g. virtual IPs) that this change adds ACL hooks to for future-proofing.

…19187) * NET-5073 - ProxyConfiguration: implement various connection options * PR feedback - LocalConnection and InboundConnection do not affect exposed routes. configure L7 route destinations. fix connection proto sequence numbers. * add timeout to L7 Route Destinations

Co-authored-by: Ronald Ekambi <ronekambi@gmail.com>

Enhance the xRoute ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.

Enhance the DestinationPolicy ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.

* typo fixes and instruction corrections * typo * link path correction

* Update dns-configuration.mdx * Update website/content/docs/services/discovery/dns-configuration.mdx Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>

….0 (#19225) * Bump golang.org/x/net to 0.17.0 This resolves [CVE-2023-39325](https://nvd.nist.gov/vuln/detail/CVE-2023-39325) / [CVE-2023-44487](https://nvd.nist.gov/vuln/detail/CVE-2023-44487). * Update Go version to 1.20.10 This resolves [CVE-2023-39325](https://nvd.nist.gov/vuln/detail/CVE-2023-39325) / [CVE-2023-44487](https://nvd.nist.gov/vuln/detail/CVE-2023-44487) (`net/http`).

…icy target (#19239)

* Upgrade @hashicorp/design-system-tokens to 1.9.0 * Upgrade @hashicorp/design-system-components to 1.8.1 * Upgrade @hashicorp/design-system-components and ember-in-viewport * Explicitly install ember-modifier@4.1.0 * rename copy-button * Fix how cleanup is done in with-copyable * Update aria-menu modifier for new structure * Update css-prop modifier to new structure * Convert did-upsert to regular class modifier * Update notification modifier for new structure * Update on-oustside modifier for new structure * Move destroy handler registration in with-copyable * Update style modifier for new structure * Update validate modifier for new structure * Guard against setting on destroyed object * Upgrade @hashicorp/design-system-components to 2.14.1 * Remove debugger * Guard against null in aria-menu * Fix undefined hash in validate addon * Upgrade ember-on-resize-modifier * Fix copy button import, missing import and array destructuring --------- Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>

CE changes for multiple virtual hosts

…#19119) * NET-5592 - update Nomad integration testing * NET-4893: Ensure we're testing all the latest versions of Vault/Nomad

The control-plane-request-limit config entry does not support specifying parameter names in snake case format. This commit updates the HCL and JSON examples to use the supported camel case key format.

When testing adding http probes to apps, I ran into some issues which I fixed here: - The listener should be listening on the exposed listener port, updated that. - The listener and route names were pointing to the path of the exposed path. In my test, the path was "/" resulting in an empty string path. Also, the path may not be unique across exposed path listeners, so I decided to use the path+exposed port as the unique identifier.

* Add sentence * link text adjustment

* Update configure.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

…maid diagram with their dependencies (#19230)

…ges (#19278)

Ensure LB policy set for locality-aware routing (CE) `overprovisioningFactor` should be overridden with the expected value (100,000) when there are multiple endpoint groups. Update code and tests to enforce this. This is an Enterprise feature. This commit represents the CE portions of the change; tests are added in the corresponding `consul-enterprise` change.

* fix: allow snake case keys for ip based rate limit config entry * chore: add changelog

github-team-consul-core-pr-approver

Auto approved Consul Bot automated PR

rboyer and others added 30 commits October 13, 2023 15:32

server: run the api checks against the path without params (#19205)

20d1fb8

Clone proto into deepcopy correctly (#19204)

3d1a606

chore: update version and nightly CI for 1.17 (#19208)

9b0f4b7

Update version file to 1.18-dev, and replace 1.13 nightly test with 1.17.

mesh: add validation hook to proxy configuration (#19186)

e94d6ce

mesh: add more validations to Destinations resource (#19202)

2ea33e9

Relplat 897 copywrite bot workarounds (#19200)

3716b69

Co-authored-by: Ronald Ekambi <ronekambi@gmail.com>

mesh: add xRoute ACL hook tenancy tests (#19177)

6c7d075

Enhance the xRoute ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.

resource: enforce lowercase v2 resource names (#19218)

ad17769

mesh: add DestinationPolicy ACL hook tenancy tests (#19178)

df8ea43

Enhance the DestinationPolicy ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.

catalog: add FailoverPolicy ACL hook tenancy test (#19179)

6741392

docs: Multi-port corrections (#19224)

dcd5930

* typo fixes and instruction corrections * typo * link path correction

Add reason why port 53 is not used by default (#19222)

b81c862

* Update dns-configuration.mdx * Update website/content/docs/services/discovery/dns-configuration.mdx Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>

v2tenancy: rename v1alpha1 -> v2beta1 (#19227)

4c5a46e

NET-6097 - sidecar proxy controller - give name to first failover pol…

9f4f99c

…icy target (#19239)

[NET-5810] CE changes for multiple virtual hosts (#19246)

b78465b

CE changes for multiple virtual hosts

Net 4893- Ensure we're testing all the latest versions of Vault/Nomad (…

61bd08c

…#19119) * NET-5592 - update Nomad integration testing * NET-4893: Ensure we're testing all the latest versions of Vault/Nomad

docs: Fix example control-plane-request-limit HCL and JSON (#19105)

9976e08

The control-plane-request-limit config entry does not support specifying parameter names in snake case format. This commit updates the HCL and JSON examples to use the supported camel case key format.

test: add 1.17 nightly integrations test (#19253)

9b719e6

docs: Multiport HCP constraint update (#19261)

c4d6d4d

* Add sentence * link text adjustment

docs: Fix multi-port install (#19262)

16f0a24

* Update configure.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

Prevent circular dependencies between v2 resources and generate a mer…

f45be22

…maid diagram with their dependencies (#19230)

build(docker): always publish full and minor version tags for dev ima…

a94c013

…ges (#19278)

fix nightly integration test: envoy version and n-2 version (#19286)

d52ee6a

fix: allow snake case keys for ip based rate limit config entry (#19277)

2bd38d8

* fix: allow snake case keys for ip based rate limit config entry * chore: add changelog

hc-github-team-consul-core requested a review from a team November 20, 2023 14:48

hc-github-team-consul-core requested review from a team as code owners November 20, 2023 14:48

hc-github-team-consul-core force-pushed the backport/dhiaayachi/fix_panic_policy_delete/publicly-pumped-tadpole branch from e9f77a3 to 51954d5 Compare November 20, 2023 14:48

hc-github-team-consul-core requested review from marianoasselborn and randyhdev and removed request for a team November 20, 2023 14:48

hc-github-team-consul-core assigned dhiaayachi Nov 20, 2023

hc-github-team-consul-core force-pushed the backport/dhiaayachi/fix_panic_policy_delete/publicly-pumped-tadpole branch 2 times, most recently from adf8e2c to c433c99 Compare November 20, 2023 14:48

hc-github-team-consul-core enabled auto-merge (squash) November 20, 2023 14:48

hc-github-team-consul-core requested a review from dhiaayachi November 20, 2023 14:48

github-team-consul-core-pr-approver approved these changes Nov 20, 2023

View reviewed changes

dhiaayachi disabled auto-merge November 20, 2023 14:50

dhiaayachi closed this Nov 20, 2023

dhiaayachi mentioned this pull request Nov 20, 2023

do not auto merge backports #19694

Merged

github-actions bot deleted the backport/dhiaayachi/fix_panic_policy_delete/publicly-pumped-tadpole branch August 29, 2025 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport of fix a panic in the CLI when deleting an acl policy with an unknown name into release/1.17.x#19692

Backport of fix a panic in the CLI when deleting an acl policy with an unknown name into release/1.17.x#19692
hc-github-team-consul-core wants to merge 184 commits intorelease/1.17.xfrom
backport/dhiaayachi/fix_panic_policy_delete/publicly-pumped-tadpole

hc-github-team-consul-core commented Nov 20, 2023

Uh oh!

github-team-consul-core-pr-approver left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

hc-github-team-consul-core commented Nov 20, 2023

Backport

Description

PR Checklist

Uh oh!

github-team-consul-core-pr-approver left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants