Case sensitive route match

[Lord-Y]

Description

Sometimes we need route to be case insensitive when using prefix in order to apply some rules later.
Envoy is supporting this feature since a while and can be found here all the way down to version 1.22.x

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[Lord-Y]

@david-yu Can you give me a help on this PR? As we have a Consul license + support with my enterprise we tried with our account owner/CSM but no luck. You can find it in my Zendesk ticket 131683.

[jkirschner-hashicorp]

@Lord-Y : Acknowledging that I saw your message. Thank you for updating this PR against main. @david-yu / I will follow-up on this.

[hashi-derek]

This looks great so far -- thanks for the contribution. I think the main question here is about whether there's an incompatibility between the new field and regex, but otherwise, I don't see any issues.

[Lord-Y]

@hashi-derek @jkirschner-hashicorp let me know if I need to change something after my last commits.

[hashi-derek]

@Lord-Y Hey, sorry for the delay. Yeah, it looks like the CICD is complaining about a missing import during the linting step, which is preventing some tests from running.

  Error: could not import github.com/hashicorp/consul/agent/xds (-: # github.com/hashicorp/consul/agent/xds
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb) (typecheck)
  Error: "github.com/hashicorp/consul/agent/proxycfg-sources/catalog" imported as catalogproxycfg and not used (typecheck)
  Error: : # github.com/hashicorp/consul/agent/xds [github.com/hashicorp/consul/agent/xds.test]
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb (typecheck)
  Error: could not import github.com/hashicorp/consul/agent/xds (-: # github.com/hashicorp/consul/agent/xds
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb) (typecheck)
  Error: could not import github.com/hashicorp/consul/agent/xds (-: # github.com/hashicorp/consul/agent/xds
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb) (typecheck)

[Lord-Y]

@Lord-Y Hey, sorry for the delay. Yeah, it looks like the CICD is complaining about a missing import during the linting step, which is preventing some tests from running.

  Error: could not import github.com/hashicorp/consul/agent/xds (-: # github.com/hashicorp/consul/agent/xds
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb) (typecheck)
  Error: "github.com/hashicorp/consul/agent/proxycfg-sources/catalog" imported as catalogproxycfg and not used (typecheck)
  Error: : # github.com/hashicorp/consul/agent/xds [github.com/hashicorp/consul/agent/xds.test]
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb (typecheck)
  Error: could not import github.com/hashicorp/consul/agent/xds (-: # github.com/hashicorp/consul/agent/xds
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb) (typecheck)
  Error: could not import github.com/hashicorp/consul/agent/xds (-: # github.com/hashicorp/consul/agent/xds
  Error: agent/xds/routes.go:863:22: undefined: wrapperspb) (typecheck)

I don't know this happened as I didn't do anything special. I updated the code with last commits. Let's see how it's going to be.

[hashi-derek]

@Lord-Y I pushed a commit to your repo to fix the import issue and added in a changelog. All the tests passed, so thank you for the contribution.

[david-yu]

@Lord-Y What version of Consul enterprise are you using? We may need to consider backporting this but would like to check.

[rrondeau]

Hi
We are using 1.17 since last week in production.
@Lord-Y and i work together.
Thanks for fixing the test suite.

[hashi-derek]

This PR needs to be squashed for backporting purposes, and I will have to rebase the commits so that code from main doesn't sneak into 1.17 (due to the several merge commits in the middle of it). I will address this tomorrow, but figured I should point this out in case you see some activity in @Lord-Y 's branch.

[david-yu]

@Lord-Y It looks like this just missed the cut for 1.17.2 which is coming out this week, this will be delivered as part of 1.17.3. Sorry for the delay here, but I hope this ok timing wise.