Backport of [Docs] Update admin-partitions.mdx into release/1.15.x#19630
Merged
im2nguyen merged 2 commits intorelease/1.15.xfrom Nov 14, 2023
Merged
Backport of [Docs] Update admin-partitions.mdx into release/1.15.x#19630im2nguyen merged 2 commits intorelease/1.15.xfrom
im2nguyen merged 2 commits intorelease/1.15.xfrom
Conversation
cbfdf86 to
ee9dd5e
Compare
a38894c to
3ce5fca
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 14, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Collaborator
Author
|
🤔 This PR has changes in the |
im2nguyen
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18430 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@im2nguyen
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Adding a note on DNS queries requiring the presence of a Consul Client in the Admin partition
Testing & Reproduction steps
The consul-dns endpoints are the consul clients and servers as seen In the Helm chart consul/templates/dns-service.yaml
selector:
app: {{ template "consul.name" . }}
release: "{{ .Release.Name }}"
hasDNS: "true"
All components have the first two labels for app and release but only consul clients and servers have the last one hasDNS so it will only match clients AND servers
grep hasDNS ./* 2> /dev/null
./client-daemonset.yaml: hasDNS: "true"
./dns-service.yaml: hasDNS: "true"
./server-statefulset.yaml: hasDNS: "true"
PR Checklist
Overview of commits