Backport of test/deployer: add the method of deregistering services into release/1.17.x#19568
Merged
hc-github-team-consul-core merged 1 commit intorelease/1.17.xfrom Nov 7, 2023
Conversation
de09d23 to
762ff43
Compare
20d9439 to
d5d5745
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 7, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19525 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
For certain test scenarios, we need to detect if server agent can update the service endpoint after some instances are removed during relaunch (e.g., the snapshot restore scenario). In this case, the service instance needs to be removed from the catalog.
This PR adds the method of deregistering the services when a node is disabled during relaunch.
Testing & Reproduction steps
Links
PR Checklist
Overview of commits